alamb commented on code in PR #2204:
URL: https://github.com/apache/arrow-rs/pull/2204#discussion_r932153362
##########
object_store/src/azure.rs:
##########
@@ -570,73 +579,126 @@ fn url_from_env(env_name: &str, default_url: &str) ->
Result<Url> {
Ok(url)
}
-/// Configure a connection to container with given name on Microsoft Azure
-/// Blob store.
+/// Configure a connection to Mirosoft Azure Blob Storage bucket using
+/// the specified credentials.
///
-/// The credentials `account` and `access_key` must provide access to the
-/// store.
-pub fn new_azure(
- account: impl Into<String>,
- access_key: impl Into<String>,
- container_name: impl Into<String>,
+/// # Example
+/// ```
+/// # let ACCOUNT = "foo";
+/// # let BUCKET_NAME = "foo";
+/// # let ACCESS_KEY = "foo";
+/// # let CONTAINER_NAME = "foo";
+/// let azure = object_store::azure::MicrosoftAzureBuilder::new()
+/// .with_account(ACCOUNT)
+/// .with_access_key(ACCESS_KEY)
+/// .with_container_name(CONTAINER_NAME)
+/// .build();
+/// ```
+#[derive(Debug, Default)]
+pub struct MicrosoftAzureBuilder {
+ account: Option<String>,
+ access_key: Option<String>,
+ container_name: Option<String>,
Review Comment:
not sure if I should also call this `bucket_name` (generic term) or
`container_name` (Azure specific term). I kept the existing naming convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
