tustvold commented on code in PR #2231:
URL: https://github.com/apache/arrow-rs/pull/2231#discussion_r933628205
##########
parquet/src/data_type.rs:
##########
@@ -658,20 +658,8 @@ pub(crate) mod private {
_: &mut W,
bit_writer: &mut BitWriter,
) -> Result<()> {
- if bit_writer.bytes_written() + values.len() / 8 >=
bit_writer.capacity() {
Review Comment:
This is a little bit funky, bool::encode would actually increase the
BitWriter capacity instead of erroring :sweat_smile: This is now done
automatically everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
