alamb commented on code in PR #2239: URL: https://github.com/apache/arrow-rs/pull/2239#discussion_r933811529
########## arrow/tests/schema.rs: ########## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::datatypes::{DataType, Field, Schema}; +use std::collections::HashMap; +/// The tests in this file ensure a `Schema` can be manipulated +/// outside of the arrow crate + +#[test] +fn schema_destructure() { Review Comment: > Do we need to move outside the tests of other public members to make sure they can be used outside the arrow crate? If we have such tests then yes I think they need to be outside the crate. In general, actually, moving some of the arrow testing into separate integration tests might be good for the compile/test/change cycle. However, I don't think we should go overboard and try to write tests for all `pub` fields -- I felt this was in particular special (mostly because I don't want someone in the future to remove the `pub` thinking it won't affect anyone) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
