HaoYang670 commented on code in PR #2247:
URL: https://github.com/apache/arrow-rs/pull/2247#discussion_r933976652
##########
arrow/src/array/array_decimal.rs:
##########
@@ -219,6 +222,16 @@ pub trait BasicDecimalArray<T: BasicDecimal, U:
From<ArrayData>>:
let array_data = unsafe { builder.build_unchecked() };
U::from(array_data)
}
+
+ /// The default precision and scale used when not specified.
+ fn default_type() -> DataType {
+ // Keep maximum precision
Review Comment:
Could we make the `default_type` to be a `const` value or `const` function?
As it could be computed at compile time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
