tustvold commented on code in PR #2237:
URL: https://github.com/apache/arrow-rs/pull/2237#discussion_r933983857
##########
parquet/src/arrow/array_reader/complex_object_array.rs:
##########
@@ -160,6 +181,10 @@ where
array = arrow::compute::cast(&array, &self.data_type)?;
}
+ self.data_buffer = vec![];
+ self.def_levels_buffer = None;
+ self.rep_levels_buffer = None;
Review Comment:
I think this will break, as parent ArrayReader assume the definition levels
live until the next call to consume_batch?
I'm not sure we actually have test coverage of say a nullable StructArray
containing a DecimalArray 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
