nevi-me commented on code in PR #2221:
URL: https://github.com/apache/arrow-rs/pull/2221#discussion_r934041210
##########
parquet/src/column/writer/encoder.rs:
##########
@@ -77,6 +91,9 @@ pub trait ColumnValueEncoder {
/// Write the corresponding values to this [`ColumnValueEncoder`]
fn write(&mut self, values: &Self::Values, offset: usize, len: usize) ->
Result<()>;
+ /// Write the corresponding values to this [`ColumnValueEncoder`]
Review Comment:
```suggestion
/// Write the corresponding values to this [`ColumnValueEncoder`] by
gathering indexed values
```
##########
parquet/src/column/writer/encoder.rs:
##########
@@ -77,6 +91,9 @@ pub trait ColumnValueEncoder {
/// Write the corresponding values to this [`ColumnValueEncoder`]
fn write(&mut self, values: &Self::Values, offset: usize, len: usize) ->
Result<()>;
+ /// Write the corresponding values to this [`ColumnValueEncoder`]
Review Comment:
From the comment of `write` and this fn, it's unclear what the difference
between the two is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
