crepererum commented on issue #2992: URL: https://github.com/apache/arrow-datafusion/issues/2992#issuecomment-1200908122
Looks good. I would however advice you to NOT use `Box<dyn Fn...>` but `Box<dyn Opener>` with a new trait `Opener` because this later allows you to more easily add new functions (like `as_any(&self) -> dyn Any`, or `name(&self) -> &'static str`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
