alamb commented on code in PR #2235:
URL: https://github.com/apache/arrow-rs/pull/2235#discussion_r934486231
##########
arrow/src/datatypes/types.rs:
##########
@@ -264,9 +274,20 @@ impl IntervalMonthDayNanoType {
days: i32,
nanos: i64,
) -> <IntervalMonthDayNanoType as ArrowPrimitiveType>::Native {
- let m = months as u128 & u32::MAX as u128;
- let d = (days as u128 & u32::MAX as u128) << 32;
- let n = (nanos as u128) << 64;
+ /*
+
https://github.com/apache/arrow/blob/02c8598d264c839a5b5cf3109bfd406f3b8a6ba5/cpp/src/arrow/type.h#L1475
+ struct MonthDayNanos {
+ int32_t months;
+ int32_t days;
+ int64_t nanoseconds;
Review Comment:
```suggestion
int64_t nanoseconds;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
