daniel-martinez-maqueda-sap commented on code in PR #2258:
URL: https://github.com/apache/arrow-rs/pull/2258#discussion_r934629886


##########
arrow/src/compute/kernels/comparison.rs:
##########
@@ -296,6 +298,41 @@ pub fn like_utf8_scalar<OffsetSize: OffsetSizeTrait>(
     Ok(BooleanArray::from(data))
 }
 
+fn replace_like_wildcards(text: &str) -> Result<String> {
+    let text = escape(text);

Review Comment:
   Thanks for the comments.
   
   This approach is much more readable. Already applied in the next commit.
   
   Regarding the second comment. I also think it is outside of the scope of 
this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to