alamb opened a new pull request, #3008: URL: https://github.com/apache/arrow-datafusion/pull/3008
(Draft until I complete checklist below) # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> re https://github.com/apache/arrow-datafusion/issues/1474 # Rationale for this change This is part of my long term attempt to remove the macro nest in `binary.rs` The rationale is 1. Make it easier to understand what is going on in binary.rs -- everytime I try to make a change in there it takes several minutes of study to get a handle on things. 2. Help define easier to use APIs in arrow-r, and fill out the feature gaps # What changes are included in this PR? - [x] Remove `binary_primitive_array_op!` macro :tada:, replace `add_dyn`, `subtract_dyn`, `multiply_dyn` and `divide_dyn` - [ ] Remove `binary_primitive_array_op_scalar` mcacro, replace with `add_dyn_scalar`, `subtract_dyn_scalar`, `multiply_dyn_scalar` and `divide_dyn_scalar` - [ ] Add wrapper - [ ] File follow on tickets in arrow-rs # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
