avantgardnerio commented on PR #3007:
URL:
https://github.com/apache/arrow-datafusion/pull/3007#issuecomment-1201689127
I fixed a lot of the obvious errors, but I wasn't sure what to do about
```
error[E0308]: mismatched types
--> datafusion/physical-expr/src/expressions/binary.rs:135:40
|
135 | .map(|left| left.map(|left| op(left, right)))
| -- ^^^^ expected `i128`, found
struct `arrow::util::decimal::Decimal128`
| |
| arguments to this function are
incorrect
|
note: callable defined here
--> datafusion/physical-expr/src/expressions/binary.rs:131:8
|
131 | F: Fn(i128, i128) -> bool,
| ^^^^^^^^^^^^^^^^^^^^^^
```
and
```
error[E0308]: mismatched types
--> datafusion/physical-expr/src/expressions/in_list.rs:225:68
|
225 | .map(|vop| match vop.map(|v|
!$VALUES.contains(&v)) {
| -------- ^^
expected `i128`, found struct `arrow::util::decimal::Decimal128`
| |
| arguments
to this function are incorrect
...
318 | collection_contains_check!(array, values, negated, contains_null)
| -----------------------------------------------------------------
in this macro invocation
|
= note: expected reference `&i128`
found reference `&arrow::util::decimal::Decimal128`
note: associated function defined here
-->
/home/bgardner/snap/rustup/common/rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/mod.rs:2172:12
|
2172 | pub fn contains(&self, x: &T) -> bool
| ^^^^^^^^
= note: this error originates in the macro `collection_contains_check`
(in Nightly builds, run with -Z macro-backtrace for more info)
```
CC @andygrove and @alamb - if you guys have any advice, it would be
appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
