thisisnic commented on code in PR #233:
URL: https://github.com/apache/arrow-cookbook/pull/233#discussion_r935476228
##########
r/content/reading_and_writing_data.Rmd:
##########
@@ -304,6 +304,39 @@ test_that("read_json_arrow chunk works as expected", {
unlink(tf)
```
+### Discussion
Review Comment:
Agreed - there's a really delicate balance to be struck here between
"explaining how to do things using the arrow package" (desirable) and
"explaining how to do things using the tidyverse in general" (undesirable).
We've come up against this in the past, when [writing the recipe for using
dplyr verbs in
arrow](https://arrow.apache.org/cookbook/r/manipulating-data---tables.html#use-dplyr-verbs-in-arrow),
and making a conscious choice _not_ to detail each of the main dplyr verbs
that we support (as this is dplyr content and not arrow content).
I think you're right @eitsupi that it could be helpful to point readers in
the right direction here but agree with @dragosmg that this level of detail is
a little out-of-scope and that a brief sentence with a link would be best in
this particular case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
