dragosmg commented on PR #13620:
URL: https://github.com/apache/arrow/pull/13620#issuecomment-1202638699
I see what you mean. I guess it depends on the point of view. If you look
at it as the state of the package pre-merge (my branch) then the lint is a
false-positive (which is AFAICT should be the case). If you look at it as the
state of the package post-merge (the master) then the picked-up lint was _not_
a false-positive.
As you say, regardless of the POV, the authors' recommended workflow is to
install the package before linting.
Installing the package, AFAIU, will lint the branch version of the package
and not the master one.
If my understanding is correct, it points to a way we could test this.
Introduce a lint in a new file in master. With the old workflow any subsequent
PR should pick-up this lint (even if the affected file is not touched), while
with the new CI workflow, the lint in master should not be picked-up (if the
file isn't present in the branch).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
