joosthooz commented on PR #13709: URL: https://github.com/apache/arrow/pull/13709#issuecomment-1203123960
That sums it up very nicely. Both alternatives are fine with me. I just pushed an update that aims to do what you suggest, which is adding an `encoding` field to the C++ struct. The CSV reader returns an `Invalid` error when the user has specified an encoding other than UTF-8 but the `stream_transform_func` is empty. Is that the right error type or would an `IOError` be more suitable? How do you feel about the name of the `set_transcoder` function in `CsvFragmentScanOptions`? Should I add a docstring to it? Should the `stream_transform_func` be added to the equals() function? (in that case I think I need to add a getter/setting for it too) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
