tustvold commented on code in PR #2297:
URL: https://github.com/apache/arrow-rs/pull/2297#discussion_r936536956
##########
arrow/src/array/equal_json.rs:
##########
@@ -127,11 +127,18 @@ impl<OffsetSize: OffsetSizeTrait>
PartialEq<GenericListArray<OffsetSize>> for Va
impl<T: ArrowPrimitiveType> JsonEqual for DictionaryArray<T> {
fn equals_json(&self, json: &[&Value]) -> bool {
- // todo: this is wrong: we must test the values also
+ // TODO: this is wrong: we must test the values also (#2294)
self.keys().equals_json(json)
}
}
+impl<'a, K: ArrowPrimitiveType, V> JsonEqual for TypedDictionaryArray<'a, K,
V> {
Review Comment:
I created #2294 to track this issue and #2296 to track removing JsonEqual
##########
arrow/src/array/equal_json.rs:
##########
@@ -127,11 +127,18 @@ impl<OffsetSize: OffsetSizeTrait>
PartialEq<GenericListArray<OffsetSize>> for Va
impl<T: ArrowPrimitiveType> JsonEqual for DictionaryArray<T> {
fn equals_json(&self, json: &[&Value]) -> bool {
- // todo: this is wrong: we must test the values also
+ // TODO: this is wrong: we must test the values also (#2294)
self.keys().equals_json(json)
}
}
+impl<'a, K: ArrowPrimitiveType, V> JsonEqual for TypedDictionaryArray<'a, K,
V> {
Review Comment:
I created #2294 to track this issue and #2296 to suggest removing JsonEqual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
