[GitHub] [arrow] pitrou commented on a diff in pull request #13780: ARROW-17252: [R] Intermittent valgrind failure (explicit StopProducing approach)

Wed, 03 Aug 2022 05:42:56 -0700 


pitrou commented on code in PR #13780:
URL: https://github.com/apache/arrow/pull/13780#discussion_r936615852


##########
r/src/compute-exec.cpp:
##########
@@ -147,6 +147,7 @@ std::shared_ptr<arrow::Table> ExecPlan_read_table(
         return prepared_plan.second->ToTable();
       });
 
+  prepared_plan.first->StopProducing();

Review Comment:
   I would also wait for the production to actually have stopped, not merely 
ask the plan to stop.
   ```suggestion
     prepared_plan.first->StopProducing();
     StopIfNotOk(prepared_plan.first->finished().status());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to