pitrou commented on code in PR #13775:
URL: https://github.com/apache/arrow/pull/13775#discussion_r936738358
##########
cpp/thirdparty/flatbuffers/README.md:
##########
@@ -40,3 +41,126 @@ index 955738067..fccce42f6 100644
#endif // __has_include
#endif // !FLATBUFFERS_HAS_STRING_VIEW
```
+
+```diff
+diff --git a/cpp/thirdparty/flatbuffers/include/flatbuffers/base.h
b/cpp/thirdparty/flatbuffers/include/flatbuffers/base.h
+index fccce42f6..316eb2259 100644
+--- a/cpp/thirdparty/flatbuffers/include/flatbuffers/base.h
++++ b/cpp/thirdparty/flatbuffers/include/flatbuffers/base.h
+@@ -1,6 +1,11 @@
+ #ifndef FLATBUFFERS_BASE_H_
+ #define FLATBUFFERS_BASE_H_
+
++// Move this vendored copy of flatbuffers to a private namespace,
++// but continue to access it through the "flatbuffers" alias.
++namespace arrow_thirdparty_flatbuffers {}
Review Comment:
Hmm, actually that is not right, because it would then be exposed through
the linker script:
https://github.com/apache/arrow/blob/master/cpp/src/arrow/symbols.map
Perhaps `arrow_vendored_private::flatbuffers`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
