stuartcarnie commented on code in PR #3018:
URL: https://github.com/apache/arrow-datafusion/pull/3018#discussion_r937155593
##########
datafusion/sql/src/planner.rs:
##########
@@ -1613,6 +1613,13 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
&schema,
&mut HashMap::new(),
),
+ SQLExpr::TypedString {
+ ref data_type,
+ ref value,
+ } => Ok(Expr::Cast {
+ expr: Box::new(lit(&**value)),
+ data_type: convert_data_type(data_type)?,
+ }),
Review Comment:
Cool – I'll make that change as it is much cleaner! I copied this pattern
from another part of the file:
https://github.com/apache/arrow-datafusion/blob/c46d61d45eb73f11ac39d8646b2b25a4fbbc80eb/datafusion/sql/src/planner.rs#L1818-L1824
so I've updated that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
