JasonLi-cn commented on code in PR #2314:
URL: https://github.com/apache/arrow-rs/pull/2314#discussion_r937315980
##########
arrow/src/ipc/writer.rs:
##########
@@ -884,6 +884,16 @@ fn get_buffer_element_width(spec: &BufferSpec) -> usize {
}
}
+/// Returns byte width for binary value_offset buffer spec.
+#[inline]
+fn get_value_offset_byte_width(data_type: &DataType) -> usize {
+ match data_type {
+ DataType::Binary | DataType::Utf8 => 8,
+ DataType::LargeBinary | DataType::LargeUtf8 => 16,
Review Comment:
It was my negligence, should:
```rust
DataType::Binary | DataType::Utf8 => 4,
DataType::LargeBinary | DataType::LargeUtf8 => 8,
```
thanks! @HaoYang670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
