pitrou commented on a change in pull request #8177:
URL: https://github.com/apache/arrow/pull/8177#discussion_r492084011
##########
File path: cpp/src/parquet/CMakeLists.txt
##########
@@ -202,6 +203,19 @@ set(PARQUET_SRCS
stream_writer.cc
types.cc)
+if(CXX_SUPPORTS_AVX2)
+ # AVX2 is used as a proxy for BMI2.
Review comment:
According to https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html , it
seems that the following CPUs may have support for AVX2 but not BMI2: Intel
Alder Lake, Via Eden. This is obviously an extremely minor fraction of the CPU
market, but I wouldn't be surprised if some day we get some bug reports because
of it (or worse, people will decide that Arrow isn't reliable because it
crashes for some of their customers).
##########
File path: cpp/src/parquet/CMakeLists.txt
##########
@@ -202,6 +203,19 @@ set(PARQUET_SRCS
stream_writer.cc
types.cc)
+if(CXX_SUPPORTS_AVX2)
+ # AVX2 is used as a proxy for BMI2.
Review comment:
Ahah, sorry. Indeed, for some reason I had misread that `-mbmi2` would
be applied to all source files. I agree it's ok, then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
