pitrou commented on PR #13783: URL: https://github.com/apache/arrow/pull/13783#issuecomment-1205170709
Now to answer the problems with the current predicates: * +1 to adding `is_numeric`, `is_binary`, `is_string`, `is_temporal` and `is_interval` * for `is_primitive`: is "primitive" any type that's not nested nested/compound; whether or `Type::NA` should be included is a bit contentious, but otherwise all temporals, numerics (including decimals) and binary-likes should probably be included * I think `is_primitive_like` should probably be avoided; granted, we have other `is_*_like` functions, but they turn out to be confusing, so we should probably not reuse that pattern * therefore I would be in favor of changing `is_primitive` as outlined above (meaning a slight compatibility break unfortunately) Also note that the `is_*` predicates can handle parameterized types while the `*Types()` functions by essence cannot really handle them fully if there is a large or infinite number of parametrizations possible. Does that make sense? Also @lidavidm what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
