avantgardnerio commented on PR #110: URL: https://github.com/apache/arrow-ballista/pull/110#issuecomment-1205516505
Thanks for providing the link @andygrove . If I understand correctly, I think I have to agree with this comment: https://github.com/rust-lang/api-guidelines/discussions/176#discussioncomment-232635 > no way of discerning that this doc is lifted from the futures crate Except that it's not just about docs, it's about information loss. Cargo is able to maintian a DAG of dependencies and detect conflicts. If I understand correctly, if a dependency is re-exported, then this information is lost? Also, if ballista were to add another important 3rd party dependency that followed the same practice (re-exporting their own SQL parser) it would be impossible to pass a `sqlparser::ast::Statement` between the two crates in a safe way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
