kosak commented on PR #13775: URL: https://github.com/apache/arrow/pull/13775#issuecomment-1206157229
@pitrou I'm not sure *exactly* what you're asking me but I can say that I built arrow like this (before and after the change) ``` cmake -DARROW_BUILD_STATIC=ON -DARROW_FLIGHT=ON -DARROW_CSV=ON -DARROW_FILESYSTEM=ON -DARROW_DATASET=ON -DARROW_PARQUET=ON -DARROW_WITH_BZ2=ON -DARROW_WITH_ZLIB=ON -DARROW_WITH_LZ4=ON -DARROW_WITH_SNAPPY=ON -DARROW_WITH_ZSTD=ON -DARROW_WITH_BROTLI=ON -DARROW_SIMD_LEVEL=NONE .. make -j8 ``` and then I looked at the symbols from libarrow.so like this ``` nm libarrow.so | grep flatbuffers | c++filt > ~/before_ns_switch.txt ``` And I got the 84 symbols shown here: https://gist.github.com/kosak/f97a0a04f96a2c02957b33e4d110ad72 The nice thing is that if you diff the two files (before_ns_switch.txt vs after_ns_switch.txt) with a graphical diff tool like kompare, they line up perfectly and you can see the namespace getting replaced in the right place for every line. Not sure how surprising that is, but I was glad to see it visually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
