tustvold commented on code in PR #2326:
URL: https://github.com/apache/arrow-rs/pull/2326#discussion_r938590173
##########
arrow/src/temporal_conversions.rs:
##########
@@ -154,3 +179,64 @@ pub fn duration_us_to_duration(v: i64) -> Duration {
pub fn duration_ns_to_duration(v: i64) -> Duration {
Duration::nanoseconds(v)
}
+
+#[cfg(test)]
+mod tests {
+ use crate::temporal_conversions::{
+ date64_to_datetime, timestamp_ms_to_datetime, timestamp_ns_to_datetime,
+ timestamp_us_to_datetime,
+ };
+ use chrono::NaiveDateTime;
+
+ #[test]
Review Comment:
Is it worth a test of an exact number of seconds, to check the branch in
split_seconds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
