jorisvandenbossche commented on code in PR #13793:
URL: https://github.com/apache/arrow/pull/13793#discussion_r938634613
##########
cpp/src/arrow/io/interfaces.h:
##########
@@ -262,8 +262,8 @@ class ARROW_EXPORT RandomAccessFile : public InputStream,
public Seekable {
/// \param[in] file_offset the starting position in the file
/// \param[in] nbytes the extent of bytes to read. The file should have
/// sufficient bytes available
- static std::shared_ptr<InputStream>
GetStream(std::shared_ptr<RandomAccessFile> file,
- int64_t file_offset, int64_t
nbytes);
+ static Result<std::shared_ptr<InputStream>> GetStream(
+ std::shared_ptr<RandomAccessFile> file, int64_t file_offset, int64_t
nbytes);
Review Comment:
@pitrou should we keep the original non-Result signature as well for
backwards compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
