HaoYang670 commented on code in PR #2327:
URL: https://github.com/apache/arrow-rs/pull/2327#discussion_r938760056
##########
arrow/src/array/array_list.rs:
##########
@@ -57,6 +60,16 @@ pub struct GenericListArray<OffsetSize> {
}
impl<OffsetSize: OffsetSizeTrait> GenericListArray<OffsetSize> {
+ /// The data type constructor of list array.
+ /// The input is the schema of the child array and
+ /// the output is the [`DataType`], List or LargeList.
+ pub const DATA_TYPE_CONSTRUCTOR: fn(Box<Field>) -> DataType = if
OffsetSize::IS_LARGE
Review Comment:
Thank you for your review @alamb. Personally, I prefer the name
`CONSTRUCTOR`, as `ListArray` and `LargeListArray` constructor tags of
`DataType`:
https://en.wikipedia.org/wiki/Algebraic_data_type#:~:text=A%20general%20algebraic%20data%20type,factors%20of%20the%20product%20type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
