iChauster commented on code in PR #13771:
URL: https://github.com/apache/arrow/pull/13771#discussion_r938924554
##########
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##########
@@ -49,6 +49,20 @@ static Result<TableStats> MakeTable(const
TableGenerationProperties& properties)
return Result<TableStats>({table, rows, rows * row_size});
}
+// As opposed to using table_source, we create a make a ReaderGenerator for
the specified
+// table. This allows us to specify a thread pool to isolate the threads used
for each
+// source as an anti-deadlocking mechanism.
+static ExecNode* MakeTableSourceNode(std::shared_ptr<arrow::compute::ExecPlan>
plan,
Review Comment:
Change to `ExecPlan*`!
##########
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##########
@@ -49,6 +49,20 @@ static Result<TableStats> MakeTable(const
TableGenerationProperties& properties)
return Result<TableStats>({table, rows, rows * row_size});
}
+// As opposed to using table_source, we create a make a ReaderGenerator for
the specified
+// table. This allows us to specify a thread pool to isolate the threads used
for each
+// source as an anti-deadlocking mechanism.
+static ExecNode* MakeTableSourceNode(std::shared_ptr<arrow::compute::ExecPlan>
plan,
Review Comment:
Changed to `ExecPlan*`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
