alamb commented on code in PR #3009:
URL: https://github.com/apache/arrow-datafusion/pull/3009#discussion_r939155682
##########
datafusion/core/tests/sql/aggregates.rs:
##########
@@ -286,6 +286,156 @@ async fn csv_query_median_3() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn median_i8() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Int8,
+ Arc::new(Int8Array::from(vec![i8::MIN, i8::MIN, 100, i8::MAX])),
+ "-14",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_i16() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Int16,
+ Arc::new(Int16Array::from(vec![i16::MIN, i16::MIN, 100, i16::MAX])),
+ "-16334",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_i32() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Int32,
+ Arc::new(Int32Array::from(vec![i32::MIN, i32::MIN, 100, i32::MAX])),
+ "-1073741774",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_i64() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Int64,
+ Arc::new(Int64Array::from(vec![i64::MIN, i64::MIN, 100, i64::MAX])),
+ "-4611686018427388000",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_u8() -> Result<()> {
Review Comment:
nice
##########
datafusion/core/tests/sql/mod.rs:
##########
@@ -127,7 +127,13 @@ where
l.as_ref().parse::<f64>().unwrap(),
r.as_str().parse::<f64>().unwrap(),
);
- assert!((l - r).abs() <= 2.0 * f64::EPSILON);
+ if l.is_nan() || r.is_nan() {
Review Comment:
👍
##########
datafusion/core/tests/sql/aggregates.rs:
##########
@@ -286,6 +286,156 @@ async fn csv_query_median_3() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn median_i8() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Int8,
+ Arc::new(Int8Array::from(vec![i8::MIN, i8::MIN, 100, i8::MAX])),
+ "-14",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_i16() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Int16,
+ Arc::new(Int16Array::from(vec![i16::MIN, i16::MIN, 100, i16::MAX])),
+ "-16334",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_i32() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Int32,
+ Arc::new(Int32Array::from(vec![i32::MIN, i32::MIN, 100, i32::MAX])),
+ "-1073741774",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_i64() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Int64,
+ Arc::new(Int64Array::from(vec![i64::MIN, i64::MIN, 100, i64::MAX])),
+ "-4611686018427388000",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_u8() -> Result<()> {
+ median_test(
+ "median",
+ DataType::UInt8,
+ Arc::new(UInt8Array::from(vec![u8::MIN, u8::MIN, 100, u8::MAX])),
+ "50",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_u16() -> Result<()> {
+ median_test(
+ "median",
+ DataType::UInt16,
+ Arc::new(UInt16Array::from(vec![u16::MIN, u16::MIN, 100, u16::MAX])),
+ "50",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_u32() -> Result<()> {
+ median_test(
+ "median",
+ DataType::UInt32,
+ Arc::new(UInt32Array::from(vec![u32::MIN, u32::MIN, 100, u32::MAX])),
+ "50",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_u64() -> Result<()> {
+ median_test(
+ "median",
+ DataType::UInt64,
+ Arc::new(UInt64Array::from(vec![u64::MIN, u64::MIN, 100, u64::MAX])),
+ "50",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_f32() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Float32,
+ Arc::new(Float32Array::from(vec![1.1, 4.4, 5.5, 3.3, 2.2])),
+ "3.3",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_f64() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Float64,
+ Arc::new(Float64Array::from(vec![1.1, 4.4, 5.5, 3.3, 2.2])),
+ "3.3",
+ )
+ .await
+}
+
+#[tokio::test]
+async fn median_f64_nan() -> Result<()> {
+ median_test(
+ "median",
+ DataType::Float64,
+ Arc::new(Float64Array::from(vec![1.1, f64::NAN, f64::NAN, f64::NAN])),
+ "NaN", // probably not the desired behavior? - see
https://github.com/apache/arrow-datafusion/issues/3039
+ )
+ .await
+}
+
+#[tokio::test]
+async fn approx_median_f64_nan() -> Result<()> {
+ median_test(
+ "approx_median",
+ DataType::Float64,
+ Arc::new(Float64Array::from(vec![1.1, f64::NAN, f64::NAN, f64::NAN])),
+ "NaN", // probably not the desired behavior? - see
https://github.com/apache/arrow-datafusion/issues/3039
Review Comment:
testing for the win!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
