GPSnoopy commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r492615499
##########
File path: cpp/src/arrow/util/compression.h
##########
@@ -30,7 +30,18 @@ namespace arrow {
struct Compression {
/// \brief Compression algorithm
- enum type { UNCOMPRESSED, SNAPPY, GZIP, BROTLI, ZSTD, LZ4, LZ4_FRAME, LZO,
BZ2 };
+ enum type {
Review comment:
Are those the same enums as exposed by Parquet public API?
If so, this would be a break of ABI compatibility. Also could we start
explicitly numbering these, and maybe add a comment, so that the next person
doesn't break ABI compatibility without realising it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
