liukun4515 commented on code in PR #1855:
URL: https://github.com/apache/arrow-rs/pull/1855#discussion_r939500556
##########
arrow/Cargo.toml:
##########
@@ -83,6 +86,8 @@ rand = { version = "0.8", default-features = false, features
= ["std", "std_rng
criterion = { version = "0.3", default-features = false }
flate2 = { version = "1", default-features = false, features =
["rust_backend"] }
tempfile = { version = "3", default-features = false }
+lz4 = { version = "1.23", default-features = false }
+zstd = { version = "0.11", default-features = false }
Review Comment:
I try to remove these from the dev-dependency, can run `cargo test`.
I got the compile error.
```
error[E0433]: failed to resolve: use of undeclared crate or module `lz4`
--> arrow/src/ipc/compression/ipc_compression.rs:57:39
|
57 | let mut encoder =
lz4::EncoderBuilder::new().build(output)?;
| ^^^ use of undeclared crate or
module `lz4`
error[E0433]: failed to resolve: use of undeclared crate or module `zstd`
--> arrow/src/ipc/compression/ipc_compression.rs:65:39
|
65 | let mut encoder = zstd::Encoder::new(output, 0)?;
| ^^^^ use of undeclared crate or
module `zstd`
|
help: there is a crate or module with a similar name
|
65 | let mut encoder = std::Encoder::new(output, 0)?;
| ~~~
```
@alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
