liukun4515 commented on issue #2343: URL: https://github.com/apache/arrow-rs/issues/2343#issuecomment-1207198659
> Hi @liukun4515 > > Are you suggesting that the constants such as `MAX_DECIMAL_FOR_EACH_PRECISION` etc should not be `pub` because you plan to change them in the future as part of #2320 ? > > For anyone else who is interested, here is a link to the constants in question for your reference: https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/datatypes/datatype.rs?L268-436&subtree=true Yes, we don't need to expose these two constant variables. But I don't know why we expose the min and max for decimal128, maybe just missing them. @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
