paleolimbot commented on code in PR #13773:
URL: https://github.com/apache/arrow/pull/13773#discussion_r939591883
##########
r/tests/testthat/test-compute.R:
##########
@@ -103,12 +105,14 @@ test_that("register_scalar_function() adds a compute
function to the registry",
Scalar$create(32L, float64())
)
- expect_identical(
- record_batch(a = 1L) %>%
- dplyr::mutate(b = times_32(a)) %>%
- dplyr::collect(),
- tibble::tibble(a = 1L, b = 32.0)
- )
+ withr::with_envvar(list(R_ARROW_COLLECT_WITH_UDF = "true"), {
Review Comment:
I see! `with_envvar()` was definitely not doing the right thing here (which
is hopefully why the last valgrind check failed). I fixed it (I think) and
requested another check!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
