kszucs commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r492693156
##########
File path: python/pyarrow/array.pxi
##########
@@ -158,24 +158,44 @@ def array(object obj, type=None, mask=None, size=None,
from_pandas=None,
Notes
-----
Localized timestamps will currently be returned as UTC (pandas's native
- representation). Timezone-naive data will be implicitly interpreted as
+ representation). Timezone-naive data will be implicitly interpreted as
UTC.
+ Converting to dictionary array will promote to a wider integer type for
+ indices if the number of distinct values cannot be represented, even if
+ the index type was explicitly set. This means that if there are more than
+ 127 values the returned dictionary array's index type will be at least
+ pa.int16() even if pa.int8() was passed to the function. Note that an
+ explicit index type will not be demoted even if it is wider than required.
+
Examples
--------
>>> import pandas as pd
>>> import pyarrow as pa
>>> pa.array(pd.Series([1, 2]))
- <pyarrow.array.Int64Array object at 0x7f674e4c0e10>
+ <pyarrow.lib.Int64Array object at 0x7f674e4c0e10>
[
1,
2
]
+ >>> pa.array(["a", "b", "a"], type=pa.dictionary(pa.int8(), pa.string()))
+ <pyarrow.lib.DictionaryArray object at 0x7feb288d9040>
+ -- dictionary:
+ [
+ "a",
+ "b"
+ ]
+ -- indices:
+ [
+ 0,
+ 1,
+ 0
+ ]
+
>>> import numpy as np
- >>> pa.array(pd.Series([1, 2]), np.array([0, 1],
- ... dtype=bool))
- <pyarrow.array.Int64Array object at 0x7f9019e11208>
+ >>> pa.array(pd.Series([1, 2]), np.array([0, 1], dtype=bool))
Review comment:
Updated.
##########
File path: python/pyarrow/tests/test_types.py
##########
@@ -280,6 +284,13 @@ def test_tzinfo_to_string_errors():
pa.lib.tzinfo_to_string(tz)
+@h.given(tzst.timezones())
+def test_timezone_roundtrip(tz):
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
