tustvold commented on code in PR #2335: URL: https://github.com/apache/arrow-rs/pull/2335#discussion_r940084025
########## parquet/src/arrow/arrow_reader/filter.rs: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::arrow::ProjectionMask; +use arrow::array::BooleanArray; +use arrow::error::Result as ArrowResult; +use arrow::record_batch::RecordBatch; + +/// A predicate operating on [`RecordBatch`] +pub trait ArrowPredicate: Send + 'static { + /// Returns the projection mask for this predicate + fn projection(&self) -> &ProjectionMask; + + /// Called with a [`RecordBatch`] containing the columns identified by [`Self::mask`], + /// with `true` values in the returned [`BooleanArray`] indicating rows + /// matching the predicate. + /// + /// The returned [`BooleanArray`] must not contain any nulls Review Comment: It was more I didn't realise https://docs.rs/arrow/latest/arrow/compute/kernels/filter/fn.prep_null_mask_filter.html was public :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
