tustvold commented on PR #2357: URL: https://github.com/apache/arrow-rs/pull/2357#issuecomment-1207981684
Thank you for working on this, however, I have a feeling that there is something fundamentally incorrect with the way validation for Decimal types is currently handled that warrants a more holistic review. In particular there are a number of APIs that should be unsafe, that aren't, the construction of `BasicDecimal` has unnecessary bounds checking, etc... I have asked on the ASF slack for clarification of what the purpose of the precision argument actually is, in particular what are the expected overflow/underflow characteristics. Once I have some clarity on what the correct behaviour is, I'll take a stab at fixing the issues that arise. I'm sorry that this does mean there will be a slight delay, but I think it is better that we fix this properly, as I at least am extremely confused by what the current code does... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
