TheNeuralBit commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492822710
##########
File path: js/test/unit/ipc/helpers.ts
##########
@@ -54,13 +54,13 @@ export abstract class ArrowIOTestHelper {
await testFn(await this.writer(this.table).toUint8Array());
};
}
- iterable(testFn: (iterable: Iterable<Uint8Array>) => void | Promise<void>)
{
+ iterable(testFn: (iterable: Generator<Uint8Array>) => void |
Promise<void>) {
return async () => {
expect.hasAssertions();
await testFn(chunkedIterable(await
this.writer(this.table).toUint8Array()));
};
}
- asyncIterable(testFn: (asyncIterable: AsyncIterable<Uint8Array>) => void |
Promise<void>) {
+ asyncIterable(testFn: (asyncIterable: AsyncGenerator<Uint8Array>) => void
| Promise<void>) {
Review comment:
Ah ok, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
