[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #3070: Add opening, scanning, processing metrics in file stream

Mon, 08 Aug 2022 08:56:01 -0700 


Ted-Jiang commented on code in PR #3070:
URL: https://github.com/apache/arrow-datafusion/pull/3070#discussion_r940402607


##########
datafusion/core/src/physical_plan/file_format/file_stream.rs:
##########
@@ -164,6 +206,12 @@ impl<F: FileOpener> FileStream<F> {
                     partition_values,
                 } => match ready!(future.poll_unpin(cx)) {
                     Ok(reader) => {
+                        if let Some(instant) =

Review Comment:
   looks 
   ```rust
   pub struct ScopedTimerGuard<'a> {
       inner: &'a Time,
       start: Option<Instant>,
   }
   ```
   have a lifetime need lot code change🤔 and we need three kinds timer , in 
this api i think it only calculate a total one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to