jduo commented on PR #13532: URL: https://github.com/apache/arrow/pull/13532#issuecomment-1208365057
> While it is technically ok, I think sprinkling `static_cast<size_t>` everywhere is both cumbersome (on the code writing _and_ reading sides) and will turn out fragile maintenance-wise. > > I also don't think we're very interested in ensuring highest quality support for 32-bit Windows, so I would favor an approach that's much lighter on maintenance and code writing demands. (for example by selectively disabling some warnings on 32-bit MSVC) The argument against disabling compilation warnings is that if the warnings come from a public header, it the library user inherits the warning and can't really work around it. They would need to disable the warning on their side if they report warnings as failures in their build system, which may be undesirable for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
