tustvold commented on code in PR #2377:
URL: https://github.com/apache/arrow-rs/pull/2377#discussion_r940575307
##########
parquet/src/arrow/buffer/converter.rs:
##########
@@ -17,18 +17,21 @@
use crate::data_type::{ByteArray, FixedLenByteArray, Int96};
use arrow::array::{
- Array, ArrayRef, BasicDecimalArray, BinaryArray, BinaryBuilder,
Decimal128Array,
- FixedSizeBinaryArray, FixedSizeBinaryBuilder, IntervalDayTimeArray,
- IntervalDayTimeBuilder, IntervalYearMonthArray, IntervalYearMonthBuilder,
- LargeBinaryArray, LargeBinaryBuilder, LargeStringArray, LargeStringBuilder,
- StringArray, StringBuilder, TimestampNanosecondArray,
+ Array, ArrayRef, BasicDecimalArray, Decimal128Array, FixedSizeBinaryArray,
+ FixedSizeBinaryBuilder, IntervalDayTimeArray, IntervalDayTimeBuilder,
+ IntervalYearMonthArray, IntervalYearMonthBuilder, TimestampNanosecondArray,
};
-use std::convert::{From, TryInto};
use std::sync::Arc;
use crate::errors::Result;
use std::marker::PhantomData;
+#[cfg(test)]
Review Comment:
This is kind of gross, but I hope to remove this module eventually #1661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
