alamb commented on code in PR #3083:
URL: https://github.com/apache/arrow-datafusion/pull/3083#discussion_r941469299
##########
CONTRIBUTING.md:
##########
@@ -35,6 +35,15 @@ list to help you get started.
This section describes how you can get started at developing DataFusion.
+### Windows setup
+
+```shell
Review Comment:
Is this still correct? Does it need any additional explination?
##########
datafusion/core/Cargo.toml:
##########
@@ -56,17 +56,17 @@ unicode_expressions =
["datafusion-physical-expr/regex_expressions", "datafusion
[dependencies]
ahash = { version = "0.7", default-features = false }
apache-avro = { version = "0.14", optional = true }
-arrow = { version = "19.0.0", features = ["prettyprint"] }
+arrow = { git = "https://github.com/apache/arrow-rs.git";, rev =
"30c94dbf1c422f81f8520b9956e96ab7b53c3f47", features = ["prettyprint"],
optional = false }
async-trait = "0.1.41"
bytes = "1.1"
chrono = { version = "0.4", default-features = false }
-datafusion-common = { path = "../common", version = "10.0.0", features =
["parquet", "object_store"] }
-datafusion-expr = { path = "../expr", version = "10.0.0" }
-datafusion-jit = { path = "../jit", version = "10.0.0", optional = true }
-datafusion-optimizer = { path = "../optimizer", version = "10.0.0" }
-datafusion-physical-expr = { path = "../physical-expr", version = "10.0.0" }
-datafusion-row = { path = "../row", version = "10.0.0" }
Review Comment:
I can't remember if the versions are needed to `cargo publish` these crates
to crates.io -- perhaps @andygrove remembers / knows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
