ManManson commented on code in PR #13804:
URL: https://github.com/apache/arrow/pull/13804#discussion_r941483162
##########
cpp/src/arrow/dataset/dataset.h:
##########
@@ -134,6 +135,8 @@ class ARROW_DS_EXPORT InMemoryFragment : public Fragment {
/// @}
+using FragmentGenerator = AsyncGenerator<std::shared_ptr<Fragment>>;
Review Comment:
Actually I would want to introduce something like `async_generator_fwd.h`
and place the main definitions (both `using`:s and class definitions like
`PushGenerator` etc.) there. Just in case `AsyncGenerator` becomes something
more elaborate than a plain `std::function`, your approach would require a lot
of patching "here and there".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
