viirya commented on code in PR #2389:
URL: https://github.com/apache/arrow-rs/pull/2389#discussion_r941556020
##########
arrow/src/array/array_decimal.rs:
##########
@@ -90,10 +84,10 @@ pub struct BasicDecimalArray<const BYTE_WIDTH: usize> {
impl<const BYTE_WIDTH: usize> BasicDecimalArray<BYTE_WIDTH> {
pub const VALUE_LENGTH: i32 = BYTE_WIDTH as i32;
- pub const DEFAULT_TYPE: DataType =
BasicDecimal::<BYTE_WIDTH>::DEFAULT_TYPE;
+ const DEFAULT_TYPE: DataType = BasicDecimal::<BYTE_WIDTH>::DEFAULT_TYPE;
Review Comment:
We have `default_type` so this can be hidden.
##########
arrow/src/array/array_decimal.rs:
##########
@@ -75,12 +75,6 @@ pub type Decimal128Array = BasicDecimalArray<16>;
pub type Decimal256Array = BasicDecimalArray<32>;
-mod private_decimal {
- pub trait DecimalArrayPrivate {
Review Comment:
not used anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
