jorisvandenbossche commented on code in PR #13629:
URL: https://github.com/apache/arrow/pull/13629#discussion_r941695546
##########
python/pyarrow/tests/parquet/test_metadata.py:
##########
@@ -533,6 +536,44 @@ def test_metadata_exceeds_message_size():
metadata = pq.read_metadata(pa.BufferReader(buf))
+def test_metadata_schema_filesystem(tmpdir):
+ table = pa.table({"a": [1, 2, 3]})
+
+ # URI writing to local file.
+ fname = "data.parquet"
+ file_path = 'file:///' + os.path.join(str(tmpdir), fname)
+
+ pq.write_table(table, file_path)
+
+ # Get expected `metadata` from path.
+ metadata = pq.read_metadata(tmpdir / fname)
+ schema = table.schema
+
+ assert pq.read_metadata(file_path).equals(metadata)
+ assert pq.read_metadata(
+ fname, filesystem=f'file:///{tmpdir}').equals(metadata)
+
+ assert pq.read_schema(file_path).equals(schema)
+ assert pq.read_schema(fname, filesystem=f'file:///{tmpdir}').equals(schema)
+
+ with util.change_cwd(tmpdir):
+ # Pass `filesystem` arg
+ assert pq.read_metadata(
+ fname, filesystem=LocalFileSystem()).equals(metadata)
+ assert pq.read_metadata(
+ fname, filesystem=LocalFileSystem.get_instance()).equals(metadata)
Review Comment:
The new LocalFileSystem has no `get_instance()` method, so I think you can
just remove this case (since the line above already includes the case of a
plain LocalFileSystem())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
