drin commented on PR #13487: URL: https://github.com/apache/arrow/pull/13487#issuecomment-1209908798
This PR is ready for review. based on how long this has been opened, I tried to get important coverage through `util/hashing_benchmark.cc` and handle the main data types. This PR does not: * address whether the hash functions are "acceptable" statistically * comprehensively benchmark, or test, the various data types I think this PR is mostly a first pass at creating some hash functions that can be called through the compute API. I will create a few issues related to ARROW-8991 to track future improvements -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
