milesgranger commented on code in PR #13821:
URL: https://github.com/apache/arrow/pull/13821#discussion_r942001260
##########
python/pyarrow/_parquet.pyx:
##########
@@ -1222,7 +1223,9 @@ cdef class ParquetReader(_Weakrefable):
self.source = source
- get_reader(source, use_memory_map, &rd_handle)
+ nf = get_native_file(source, use_memory_map)
+ (&rd_handle)[0] =
<shared_ptr[CRandomAccessFile]>nf.get_random_access_file()
+ self.nf = nf
Review Comment:
Copy that. Initially I planned on doing this, but saw `get_native_file` and
thought using that was better than changing the API of `get_reader`, but if
that's no issue then I agree just returning it is easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
