Ted-Jiang commented on code in PR #123: URL: https://github.com/apache/arrow-ballista/pull/123#discussion_r942128290
########## ballista/rust/executor/executor_config_spec.toml: ########## @@ -103,8 +103,21 @@ type = "String" doc = "plugin dir" default = "std::string::String::from(\"\")" +[[param]] +name = "log_dir" +type = "String" +doc = "Log dir: a path to save log. This will create a new storage directory at the specified path if it does not already exist." +default = "std::string::String::from(\"./logs\")" + +[[param]] +name = "print_thread_info" +type = "bool" +doc = "Enable print thread ids and names in log file." +default = "true" + [[param]] name = "log_level_setting" type = "String" doc = "special log level for sub mod. link: https://docs.rs/env_logger/latest/env_logger/#enabling-logging. For example we want whole level is INFO but datafusion mode is DEBUG" -default = "std::string::String::from(\"INFO, datafusion=INFO\")" +default = "std::string::String::from(\"INFO,datafusion=INFO\")" Review Comment: tokio-tracing pattern not support spacing between item. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
