paleolimbot commented on code in PR #13267:
URL: https://github.com/apache/arrow/pull/13267#discussion_r943015673
##########
r/R/flight.R:
##########
@@ -72,6 +74,8 @@ flight_put <- function(client, data, path, overwrite = TRUE) {
writer <- client$do_put(descriptor_for_path(path), py_data$schema)[[1]]
if (inherits(data, "RecordBatch")) {
writer$write_batch(py_data)
+ } else if (!is.null(max_chunksize)) {
Review Comment:
Oh that's ok! How about:
```r
if (inherits(data, "RecordBatch") && !is.null(max_chunksize)) {
warning("`max_chunksize` is not supported for flight_put with RecordBatch")
writer$write_batch(py_data)
} else if (inherits(data, "RecordBatch")) {
writer$write_batch(py_data)
} ...
```
(It just smells wrong to me to silently ignore it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
