[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #2405: Make the API of `fn Decimal:new` be consistent with `fn Decimal:try_new_bytes` and add length bound for `Decimal::raw_value`

Wed, 10 Aug 2022 18:46:28 -0700 


HaoYang670 commented on code in PR #2405:
URL: https://github.com/apache/arrow-rs/pull/2405#discussion_r943040551


##########
arrow/src/array/array_decimal.rs:
##########
@@ -123,6 +123,8 @@ impl<const BYTE_WIDTH: usize> BasicDecimalArray<BYTE_WIDTH> 
{
                 self.raw_value_data_ptr().offset(pos as isize),
                 Self::VALUE_LENGTH as usize,
             )
+            .try_into()

Review Comment:
   I guess there is no performance regression. I just move the `try_into` 
outside the fn `Decimal::new()`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to