liukun4515 commented on code in PR #2369:
URL: https://github.com/apache/arrow-rs/pull/2369#discussion_r943044711
##########
arrow/src/ipc/writer.rs:
##########
@@ -1096,29 +1210,56 @@ fn write_array_data(
offset,
data_ref.len(),
data_ref.null_count(),
+ compression_codec,
write_options,
- );
- });
+ )?;
+ }
}
- offset
+ Ok(offset)
}
-/// Write a buffer to a vector of bytes, and add its ipc::Buffer to a vector
+/// Write a buffer into `arrow_data`, a vector of bytes, and adds its
Review Comment:
thanks for your notes for this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
