nealrichardson commented on code in PR #13854:
URL: https://github.com/apache/arrow/pull/13854#discussion_r943608553
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -155,6 +179,71 @@ test_that("strptime", {
# RE2 library (not available on Windows with R 3.6)
skip_if_not_available("re2")
+ expect_equal(
Review Comment:
also are these all inside the same `test_that("strptime", ...`? can we break
them into separate `test_that` calls with more descriptive names, to help with
future debugging/readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
